Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error on external Node builtins in libraries #7348

Merged
merged 1 commit into from Nov 23, 2021
Merged

Do not error on external Node builtins in libraries #7348

merged 1 commit into from Nov 23, 2021

Conversation

devongovett
Copy link
Member

Fixes #7329

@height
Copy link

height bot commented Nov 23, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.31s -113.00ms
Cached 266.00ms -95.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 680.00ms -36.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 681.00ms -78.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 680.00ms -80.00ms 🚀
dist/legacy/index.96016b08.js 1.59kb +0.00b 996.00ms -51.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 997.00ms -51.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 996.00ms -52.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 1.18s -104.00ms 🚀
dist/modern/index.html 749.00b +0.00b 1.18s -103.00ms 🚀
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.32s -126.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.32s -125.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 669.00ms -59.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 669.00ms -62.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 10.98s -96.00ms
Cached 448.00ms -45.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.22m +1.02s
Cached 1.44s -115.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.83s +136.00ms
Cached 357.00ms -37.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 4fbc352 into v2 Nov 23, 2021
@devongovett devongovett deleted the builtin-external branch November 23, 2021 18:38
@WesleyMConner
Copy link

@devongovett - Can you offer a brief education on the merge/release flow/timeline for tickets like this one?

I am blocked on #7329; so, watching this thread.

Once the Build #20211123.7 test failures are resolved, does the fix become visible in v2.0.1 or are other steps required to exercise the fix?

Thanks!

@WesleyMConner WesleyMConner mentioned this pull request Dec 4, 2021
Closed
@mischnic mischnic mentioned this pull request Dec 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in modules from node_modules don't register and includeNodeModules not working
4 participants
@devongovett @parcel-benchmark @WesleyMConner @mischnic